lkml.org 
[lkml]   [2014]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] ACPI: reduce log level for message "ACPI: \_PR_.CPU4: failed to get CPU APIC ID"
    Date
    Commit b981513f806d (ACPI / scan: bail out early if failed to parse
    APIC ID for CPU) emits an error message if ACPI processor driver fails
    to query APIC ID for the CPU.

    Originally it's designed to catch BIOS bugs for CPU hot-addition. But
    it accidently reveals another type of BIOS bug that:
    1) BIOS implements ACPI objects for all possible instead of present
    CPUs. (It's legal per ACPI specification.)
    2) BIOS doesn't implement _STA method for CPU objects. OSPM assumes
    that all CPU objects are present and functioning and binds ACPI
    processor driver to those CPU objects, which then triggers the error
    message. According to ACPI spec, BIOS should implement _STA method
    for those absent CPUs at least.

    Though it's a BIOS bug in essential, there are some BIOSes in the fields
    which are implmented in this way. So reduce the log level from ERR to
    DEBUG to accommodate these existing BIOSes.

    Fixes: b981513f806d (ACPI / scan: bail out early if failed to parse APIC ID for CPU)
    Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
    ---
    drivers/acpi/acpi_processor.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c
    index c9311be..c29c2c3 100644
    --- a/drivers/acpi/acpi_processor.c
    +++ b/drivers/acpi/acpi_processor.c
    @@ -261,7 +261,7 @@ static int acpi_processor_get_info(struct acpi_device *device)

    apic_id = acpi_get_apicid(pr->handle, device_declaration, pr->acpi_id);
    if (apic_id < 0) {
    - acpi_handle_err(pr->handle, "failed to get CPU APIC ID.\n");
    + acpi_handle_debug(pr->handle, "failed to get CPU APIC ID.\n");
    return -ENODEV;
    }
    pr->apic_id = apic_id;
    --
    1.7.10.4


    \
     
     \ /
      Last update: 2014-01-27 08:01    [W:4.027 / U:0.368 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site