Messages in this thread | | | Date | Sun, 26 Jan 2014 20:16:37 -0800 | From | Guenter Roeck <> | Subject | Re: [lm-sensors] lm90 driver no longer working on PCs in 3.13 |
| |
On 01/26/2014 03:51 PM, Mark Brown wrote: > On Sun, Jan 26, 2014 at 02:04:06PM -0800, Guenter Roeck wrote: > >> I think I have a better idea: Surround the regulator code, or at least >> its error handling, in the lm90 driver with > >> if (IS_ENABLED(CONFIG_OF)) { >> } > >> Would that be ok ? If yes I'll submit a patch. I'll do the same in >> another driver I am working on. > > That's not going to have the desired effect in cases where DT is built > into the kernel but not in use on the current system (which is a > configuration that gets used) and will remove error handling for non-DT > systems that do have regulators set up. There's not the relationship > between this and DT that you seem think there is... > > Besides, if we're going to do a bodge like that we should do it in the > core and not in individual callers. >
Then it appears the only remedy at this time is to revert the patch.
Guenter
| |