Messages in this thread | | | Date | Mon, 27 Jan 2014 00:03:00 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] regulator: fixed: Use devm_regulator_register |
| |
On Sun, Jan 26, 2014 at 01:36:53PM -0800, Dmitry Torokhov wrote: > On Sat, Jan 25, 2014 at 11:35:54PM +0530, Manish Badarkhe wrote:
> > Use "devm_regulator_register" instead of "regulator_register" > > which simplifies the code.
> ... and also breaks the driver: now you are freeing desc->name and > desc->supply_name while regulator structures are still alive and can be > referenced from its sysfs attributes, etc.
Yup, they need to be converted to managed allocations too if the regulator_register() is going to be converted (see previous discussions on similar patches). It would be good to do so. [unhandled content-type:application/pgp-signature] | |