Messages in this thread | | | Date | Sun, 26 Jan 2014 21:27:49 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH -v2] x86: allocate cpumask during check irq vectors |
| |
* H. Peter Anvin <hpa@zytor.com> wrote:
> s/global/static/, with a big loud comment why it is okay.
It would be a global no matter which form we use, but for maintainability reasons I generally prefer a static put right before the function that uses it:
static cpumask_t mask;
static func(...) { }
That makes it really apparent that it's a global - statics are easily missed when hiding amongst local variables.
Thanks,
Ingo
| |