Messages in this thread | | | Date | Sun, 26 Jan 2014 11:23:30 -0800 | Subject | Re: [PATCH] afs: proc cells and rootcell are writeable | From | Linus Torvalds <> |
| |
On Sun, Jan 26, 2014 at 4:27 AM, David Howells <dhowells@redhat.com> wrote: > > - p = proc_create("cells", 0, proc_afs, &afs_proc_cells_fops); > + p = proc_create("cells", S_IFREG | S_IRUGO | S_IWUSR, proc_afs, &afs_proc_cells_fops); > - p = proc_create("rootcell", 0, proc_afs, &afs_proc_rootcell_fops); > + p = proc_create("rootcell", S_IFREG | S_IRUGO | S_IWUSR, proc_afs, &afs_proc_rootcell_fops);
So the S_IFREG isn't necessary.
And quite frankly, I personally think S_IRUGO | S_IWUSR is _less_ readable than 0644. It's damn hard to parse those random letter combinations, and at least I have to really think about it, in a way that the octal representation does *not* make me go "I have to think about that".
So my personal preference would be to just see that simple 0644 in proc_create. Hmm?
Linus
| |