Messages in this thread | | | Subject | Re: [Xen-devel] [PATCH] xen-blkback: fix memory leak when persistent grants are used | From | Konrad Rzeszutek Wilk <> | Date | Sun, 26 Jan 2014 13:01:14 -0500 |
| |
Matt Wilson <msw@linux.com> wrote: >On Fri, Jan 24, 2014 at 03:36:22PM +0000, Ian Campbell wrote: >> On Fri, 2014-01-24 at 09:21 +0000, Ian Campbell wrote: >> > On Thu, 2014-01-23 at 11:28 -0800, Matt Wilson wrote: >> > > From: Matt Rushton <mrushton@amazon.com> >> > > >> > > Currently shrink_free_pagepool() is called before the pages used >for >> > > persistent grants are released via free_persistent_gnts(). This >> > > results in a memory leak when a VBD that uses persistent grants >is >> > > torn down. >> > >> > This may well be the explanation for the memory leak I was >observing on >> > ARM last night. I'll give it a go and let you know. >> >> Results are a bit inconclusive unfortunately, it seems like I am >seeing >> some other leak too (or instead). >> >> Totally unscientifically it does seem to be leaking more slowly than >> before, so perhaps this patch has helped, but nothing conclusive I'm >> afraid. > >Testing here looks good. I don't know if perhaps something else is >going on with ARM... > >> I don't think that quite qualifies for a Tested-by though, sorry. > >How about an Acked-by? ;-) > >--msw
How big and often does this leak occur - that this patch fixes?
I think there is one comment from Roger that needs to be addressed? Maybe I missed the resolution?
Thanks!
| |