lkml.org 
[lkml]   [2014]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v5 1/2] sysctl: Make neg_one a standard constraint

* Ingo Molnar <mingo@kernel.org> wrote:

>
> * Aaron Tomlin <atomlin@redhat.com> wrote:
>
> > Add neg_one to the list of standard constraints.
> >
> > Signed-off-by: Aaron Tomlin <atomlin@redhat.com>
> > Acked-by: Rik van Riel <riel@redhat.com>
> > Acked-by: David Rientjes <rientjes@google.com>
> > ---
> > kernel/sysctl.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> > index 34a6047..dd531a6 100644
> > --- a/kernel/sysctl.c
> > +++ b/kernel/sysctl.c
> > @@ -122,6 +122,7 @@ extern int blk_iopoll_enabled;
> > static int sixty = 60;
> > #endif
> >
> > +static int neg_one = -1;
> > static int zero;
> > static int __maybe_unused one = 1;
> > static int __maybe_unused two = 2;
>
> So what happens if CONFIG_DETECT_HUNG_TASK is not defined and
> neg_one is unused? The compiler generates an unused variable
> warning.

Note, I fixed this up in your patch, no need to resend.

Thanks,

Ingo


\
 
 \ /
  Last update: 2014-01-25 10:21    [W:0.054 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site