Messages in this thread | | | Date | Sat, 25 Jan 2014 23:30:17 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 4/4] power_supply: bq24261 charger driver |
| |
Hi!
> +++ b/drivers/power/Makefile > @@ -59,4 +59,5 @@ obj-$(CONFIG_CHARGER_BQ24735) += bq24735-charger.o > obj-$(CONFIG_POWER_AVS) += avs/ > obj-$(CONFIG_CHARGER_SMB347) += smb347-charger.o > obj-$(CONFIG_CHARGER_TPS65090) += tps65090-charger.o > +obj-$(CONFIG_BQ24261_CHARGER) += bq24261_charger.o > obj-$(CONFIG_POWER_RESET) += reset/
Spot two inconsistencies.
> + if (ret < 0) > + dev_err(&chip->client->dev, > + "Error (%d) in reading status register(0x00)\n", > + ret);
If you have code indented 10 levels like this, you are doing something wrong.
Check codingstyle.
Maybe Rafael should be cced on the series? Pavel
| |