lkml.org 
[lkml]   [2014]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cpusets: Allocate heap only when required
On Fri, 24 Jan 2014, Li Zefan wrote:

> >> update_flag() routine uses heap only when spread_flag_changed is true. Otherwise
> >> heap isn't used, but is allocated and freed unnecessarily.
> >>
>
> but harmless
>

It's not harmless, if heap_init() fails with -ENOMEM then the write fails
even though it may not be for memory_spread_page or memory_spread_slab,
which is the minority of the callers of this function.


\
 
 \ /
  Last update: 2014-01-24 12:01    [W:0.351 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site