lkml.org 
[lkml]   [2014]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v4 13/14] spi: rspi: Add DT support
On Fri, Jan 24, 2014 at 08:44:03AM +0000, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> Cc: devicetree@vger.kernel.org
> ---
> v2:
> - Clarify RSPI/QSPI
> - Add interrupt-parent
> - s/should/must/ for #address-cells and #size-cells
> v3:
> - Add renesas,rspi-sh
> - Drop -rcar suffix for QSPI
> - Clarify num-cs
> - Implement DT support in driver
> - Changed one-line summary from "Documentation: dt: Add Renesas RSPI/QSPI
> bindings" to "spi: rspi: Add DT support"
> v4:
> - Clarify SoCtype and interrupts
> - Add clock property
> - Add QSPI example
> - Add interrupt-names
> - Add link to Renesas pinctrl
> - Rename "renesas,rspi-sh" to "renesas,rspi", to match platform device
> naming
> - spi-rspi.c:
> - Remove Soc-specific matching from spi-rspi.c given the fallback is
> mandatory
> - Things became a lot simpler due to the replacement of platform_data
> fields by the "rspi-rz" platform device binding.
> ---
> Documentation/devicetree/bindings/spi/spi-rspi.txt | 58 +++++++++++
> drivers/spi/spi-rspi.c | 106 ++++++++++++++------
> 2 files changed, 135 insertions(+), 29 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/spi/spi-rspi.txt
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-rspi.txt b/Documentation/devicetree/bindings/spi/spi-rspi.txt
> new file mode 100644
> index 000000000000..ed84299a9c61
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/spi-rspi.txt
> @@ -0,0 +1,58 @@
> +Device tree configuration for Renesas RSPI/QSPI driver
> +
> +Required properties:
> +- compatible : For Renesas Serial Peripheral Interface on legacy SH:
> + "renesas,rspi-<soctype>", "renesas,rspi" as fallback.
> + For Renesas Serial Peripheral Interface on RZ/A1H:
> + "renesas,rspi-<soctype>", "renesas,rspi-rz" as fallback.
> + For Quad Serial Peripheral Interface on R-Car Gen2:
> + "renesas,qspi-<soctype>", "renesas,qspi" as fallback.
> + Examples of valid soctypes are "sh7757" (SH),
> + "r7s72100" (RZ/A1H), "r8a7790" (R-Car H2), and
> + "r8a7791" (R-Car M2).
> +- reg : Address start and address range size of the device
> +- interrupts : 1 interrupt for RSPI cores using a single multiplexed
> + interrupt,
> + 3 interrupts (SPEI, SPRI, SPTI) for RSPI cores using
> + separate interrupts.
> +- interrupt-names : Array of strings associated with the interrupt numbers:
> + "error" for SPEI, "rx" for SPRI, and "tx" for SPTI.
> + For RSPI cores using a single multiplexed interrupt, the
> + name "mux" is optional.

Rather than defining the set of interrupts twice, it would be nice to
have interrupts defined in terms of interrupt-names:

- interrupts: a list of interrupt-specifiers, one for each entry in
interrupt-names. If interrupt-names is not present, an interrupt
specifier for a single muxed interrupt.

- interrupt-names: A list of interrupt names. Should contain (if
present):
* "error" for SPEI
* "rx" for SPRI
* "tx" to SPTI
* "mux" for a single muxed interrupt

Thanks,
Mark.


\
 
 \ /
  Last update: 2014-01-24 11:01    [W:0.131 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site