lkml.org 
[lkml]   [2014]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: allocate cpumask during check irq vectors
On Fri, Jan 24, 2014 at 12:11:07PM -0800, Yinghai Lu wrote:
> Date: Fri, 24 Jan 2014 12:11:07 -0800
> From: Yinghai Lu <yinghai@kernel.org>
> To: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
> linux-kernel@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>, Prarit
> Bhargava <prarit@redhat.com>
> Subject: [PATCH] x86: allocate cpumask during check irq vectors
> X-Mailer: git-send-email 1.8.4
>
> Fix warning:
> arch/x86/kernel/irq.c: In function check_irq_vectors_for_cpu_disable:
> arch/x86/kernel/irq.c:337:1: warning: the frame size of 2052 bytes is larger than 2048 bytes
>
> when NR_CPUS=8192
>
> We should use zalloc_cpumask_var() instead.
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
> Cc: Prarit Bhargava <prarit@redhat.com>
>
> diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
> index dbb6087..b114ee4 100644
> --- a/arch/x86/kernel/irq.c
> +++ b/arch/x86/kernel/irq.c
> @@ -277,11 +277,14 @@ int check_irq_vectors_for_cpu_disable(void)
> unsigned int this_cpu, vector, this_count, count;
> struct irq_desc *desc;
> struct irq_data *data;
> - struct cpumask affinity_new, online_new;
> + cpumask_var_t affinity_new, online_new;
> +
> + zalloc_cpumask_var(&affinity_new, GFP_KERNEL);
> + zalloc_cpumask_var(&online_new, GFP_KERNEL);
>
Hi, Yinghai

The original author Prarit Bhargava had committed a similar
patch and I ever said this function is protected by stop_machine
so GFP_KERNEL is not reliable. It should be GFP_ATOMIC.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-01-25 04:01    [W:0.044 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site