Messages in this thread Patch in this message | | | Date | Fri, 24 Jan 2014 14:51:57 -0500 | From | Steven Rostedt <> | Subject | [PATCH RT] timer: Run irq_work() even if there are no active timers |
| |
After trying hard to figure out why my i7 box was locking up with the new active_timers code, that does not run the timer softirq if there are no active timers, I took an extra look at the softirq handler and noticed that it doesn't just run timer softirqs, it also runs irq work.
This was the bug that was locking up the system. It wasn't missing a timer, it was missing irq work. By always doing the irq work callbacks, the system boots fine.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
diff --git a/kernel/timer.c b/kernel/timer.c index 46467be..7c5026e 100644 --- a/kernel/timer.c +++ b/kernel/timer.c @@ -1464,8 +1464,12 @@ void run_local_timers(void) raise_softirq(TIMER_SOFTIRQ); return; } - if (!base->active_timers) + if (!base->active_timers) { +#if defined(CONFIG_IRQ_WORK) && defined(CONFIG_PREEMPT_RT_FULL) + irq_work_run(); +#endif goto out; + } /* Check whether the next pending timer has expired */ if (time_before_eq(base->next_timer, jiffies))
| |