Messages in this thread | | | Date | Fri, 24 Jan 2014 10:38:32 -0700 | From | Shuah Khan <> | Subject | Re: [PATCH] staging/usbip: Add missing speeds to userspace speed_strings array |
| |
On 01/24/2014 10:31 AM, Thomas Pugliese wrote: > > > On Fri, 24 Jan 2014, Shuah Khan wrote: > >> On 01/24/2014 10:08 AM, Thomas Pugliese wrote: >>> >>> >>> On Wed, 22 Jan 2014, Shuah Khan wrote: >>> >>>> Add speed strings for usb wireless and 3.0 to speed_strings array. >>>> >>>> Signed-off-by: Shuah Khan <shuah.kh@samsung.com> >>>> --- >>>> drivers/staging/usbip/userspace/libsrc/usbip_common.c | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>>> diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_common.c >>>> b/drivers/staging/usbip/userspace/libsrc/usbip_common.c >>>> index 66f03cc..8cb4fcc 100644 >>>> --- a/drivers/staging/usbip/userspace/libsrc/usbip_common.c >>>> +++ b/drivers/staging/usbip/userspace/libsrc/usbip_common.c >>>> @@ -23,6 +23,8 @@ static const struct speed_string speed_strings[] = { >>>> { USB_SPEED_LOW, "1.5", "Low Speed(1.5Mbps)" }, >>>> { USB_SPEED_FULL, "12", "Full Speed(12Mbps)" }, >>>> { USB_SPEED_HIGH, "480", "High Speed(480Mbps)" }, >>>> + { USB_SPEED_WIRELESS, "2.5", "Wireless"}, >>>> + { USB_SPEED_SUPER, "5000", "Super Speed(5000Mbps)" }, >>>> { 0, NULL, NULL } >>>> }; >>>> >>>> -- >>> >>> Wireless USB supports variable speeds from 53.3Mbps to 480Mbps. I'm not >>> sure how you want to represent that but "2.5" doesn't seem to apply. >>> >> >> Would "variable" be better suited in this case? >> > > Sure. You could also use something like "53.3-480" since that would more > closely match the other entires which are numerical values in Mbps units. > > Thomas >
"53.3-480" sounds good. I will send v2 with that change. Thanks for the review.
-- Shuah
-- Shuah Khan Senior Linux Kernel Developer - Open Source Group Samsung Research America(Silicon Valley) shuah.kh@samsung.com | (970) 672-0658
| |