lkml.org 
[lkml]   [2014]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cpusets: Allocate heap only when required
On Fri, 24 Jan 2014, Tejun Heo wrote:

> > It's not harmless, if heap_init() fails with -ENOMEM then the write fails
> > even though it may not be for memory_spread_page or memory_spread_slab,
> > which is the minority of the callers of this function.
>
> And depending on details like that would actually be more harmful.
> Please remember that all writes through cgroupfs may fail under very
> high memory pressure. There's no "this specific set of writes to this
> specific knob isn't affected by memory pressure" guarantee.
>

Nobody is depending on shit, the patch is removing a completely pointless
memory allocation in braindead cpuset code. What you think is "harmful"
or "more harmful" is irrelevant, but nobody said anything about depending
on that behavior to do anything.

Thanks.


\
 
 \ /
  Last update: 2014-01-24 12:01    [W:0.191 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site