Messages in this thread | | | Date | Thu, 23 Jan 2014 19:39:45 +0000 | From | Mark Brown <> | Subject | Re: [PATCH Resend 7/8] ASoC: add snd_soc_of_parse_audio_simple_widgets for DeviceTree |
| |
On Thu, Jan 23, 2014 at 01:02:49PM +0800, Xiubo Li wrote:
> +static struct snd_soc_dapm_widget simple_widgets[] = { > + SND_SOC_DAPM_MIC("Mic", NULL), > + SND_SOC_DAPM_LINE("Line", NULL), > + SND_SOC_DAPM_HP("Hp", NULL), > + SND_SOC_DAPM_SPK("Spk", NULL), > +};
Does this mean we're restricted to a particular set of names? That seems sad and won't work if there's a desire for more than one of a given widget - the main use case I can see is multiple microphones with separate microphone biases. How about having some templates that we copy and then replace the name with the one the user supplied?
> + if (cnt <= 0) { > + dev_err(card->dev, > + "ASoC: Property '%s' does not exist or " > + "length is zero\n", propname);
Don't split error messages over lines, this makes it harder to grep for them. [unhandled content-type:application/pgp-signature] | |