lkml.org 
[lkml]   [2014]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] firmware/google: drop 'select EFI' to avoid recursive dependency
On Thu, 23 Jan 2014, Ard Biesheuvel wrote:

> The GOOGLE_SMI Kconfig symbol depends on DMI and selects EFI. This
> causes problems on other archs when introducing DMI support that
> depends on EFI, as it results in a recursive dependency:
>
> arch/arm/Kconfig:1845:error: recursive dependency detected!
> arch/arm/Kconfig:1845: symbol DMI depends on EFI
>
> Fix by changing the 'select EFI' to a 'depends on EFI'.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> drivers/firmware/google/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/google/Kconfig b/drivers/firmware/google/Kconfig
> index 2f21b0bfe653..29c8cdda82a1 100644
> --- a/drivers/firmware/google/Kconfig
> +++ b/drivers/firmware/google/Kconfig
> @@ -12,8 +12,7 @@ menu "Google Firmware Drivers"
>
> config GOOGLE_SMI
> tristate "SMI interface for Google platforms"
> - depends on ACPI && DMI
> - select EFI
> + depends on ACPI && DMI && EFI
> select EFI_VARS
> help
> Say Y here if you want to enable SMI callbacks for Google

Adding Mike Waychison <mikew@google.com> to the cc since this is his code,
but it looks good to me.

$ ./scripts/get_maintainer.pl -f drivers/firmware/google/Kconfig
linux-kernel@vger.kernel.org (open list)

I wonder why he's not listed as a recipient for patches from
get_maintainer.pl since it's clearly obvious he wrote the entire file.


\
 
 \ /
  Last update: 2014-01-23 23:21    [W:0.105 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site