lkml.org 
[lkml]   [2014]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe
    On Thu, 23 Jan 2014 19:36:33 +0000
    Mark Brown <broonie@kernel.org> wrote:

    > On Thu, Jan 23, 2014 at 07:47:56PM +0100, Tomasz Figa wrote:
    > > On 23.01.2014 19:40, Mark Brown wrote:
    >
    > > >We'd need to leave it user selectable rather than enabling it for ARM,
    > > >the whole reason this got noticed is that people are trying to build
    > > >kernels that support a wider range of devices for ARM.
    >
    > > What about making it depend on !MULTIPLATFORM and enabled by default?
    >
    > That'd work, but if we're doing that then substituting in the dynamic
    > assignment only when we hit a collision seems smoother and more general.
    > Or we could just make the core ignore all hard coded numbers if this is
    > set rather than putting ifdefs in the drivers.

    That strikes me as rather more risky. We can propogate it through the
    drivers as we are sure it is safe to do so on that platform and encourage
    driver authors to migrate. Better than a "big bang" and the inevitable
    fallout.

    We do want it user selectable, because we want people to leave it off
    unless they have a need for it - that then becomes a path towards
    eventually getting rid of them static identifiers for good.

    Alan


    \
     
     \ /
      Last update: 2014-01-23 21:21    [W:3.117 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site