lkml.org 
[lkml]   [2014]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: usbip: convert usbip-host driver to usb_device_driver
On Thu, Jan 23, 2014 at 08:36:46PM +0200, Valentina Manea wrote:
> This driver was previously an interface driver. Since USB/IP
> exports a whole device, not just an interface, it would make
> sense to be a device driver.
>
> This patch also modifies the way userspace sees and uses a
> shared device - dealing with interfaces is no longer required.

In what way is this modified? What is now different?

> --- a/drivers/usb/core/generic.c
> +++ b/drivers/usb/core/generic.c
> @@ -155,6 +155,7 @@ int usb_choose_configuration(struct usb_device *udev)
> }
> return i;
> }
> +EXPORT_SYMBOL(usb_choose_configuration);
>
> static int generic_probe(struct usb_device *udev)
> {
> diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
> index bb31597..fb0a555 100644
> --- a/drivers/usb/core/message.c
> +++ b/drivers/usb/core/message.c
> @@ -1921,6 +1921,7 @@ free_interfaces:
> usb_autosuspend_device(dev);
> return 0;
> }
> +EXPORT_SYMBOL(usb_set_configuration);
>
> static LIST_HEAD(set_config_list);
> static DEFINE_SPINLOCK(set_config_lock);

Please make both of these EXPORT_SYMBOL_GPL(), like the rest of the USB
symbols are.

thanks,

greg k-h


\
 
 \ /
  Last update: 2014-01-23 21:07    [W:0.390 / U:0.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site