lkml.org 
[lkml]   [2014]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] Add at24 based EEPROMs to the eeprom_dev hardware class
From
On Thu, Jan 23, 2014 at 5:25 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
> Hi,
>
> No need to quote the whole message if you reply only to a bit of it.
>
>> > module_init(at24_init);
>> >
>> > static void __exit at24_exit(void)
>> > {
>> > i2c_del_driver(&at24_driver);
>> > }
>> > module_exit(at24_exit);
>>
>> Couldn't you use module_i2c_driver() instead of this?
>
> He didn't write that code. It doesn't have a + at the beginning. He used
> the whole driver as context, which is highly unusual. A context of 3
> lines is usually good enough.

Right. I will send a patch addressing that separately.

>> > MODULE_DESCRIPTION("Driver for most I2C EEPROMs");
>> > MODULE_AUTHOR("David Brownell and Wolfram Sang");
>>
>> I would personally put your name in here if I were you, otherwise
>> David and Wolfram might get contacted by some people instead of you
>> (at least based on this).
>
> See above. He changed only 10 lines. Not enough for copyright IMO.

Well, it is not the Copyrights section, or you are saying the same
people should go to MODULE_AUTHOR as in the Copyrights section, even
if it is potentially several names? I thought this would be the name
of the person who put the file together even if from existing sources.

>> PS.: Fixing the broken i2c mailing list typo, and updating Wolfram's
>> address from the broken (obsolete?) version.
>
> It came through to the i2c list? What was wrong?

Yes, it did, _after_ fixing the typo in the mailing list address.
Check the original mailing list address typed for details.


\
 
 \ /
  Last update: 2014-01-23 19:41    [W:0.441 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site