Messages in this thread Patch in this message | | | Date | Thu, 23 Jan 2014 09:03:26 -0800 | From | tip-bot for Stanislav Fomichev <> | Subject | [tip:perf/urgent] perf timechart: Fix wrong SVG height |
| |
Commit-ID: 3415d8b851307c75a1e8aa16030db9172306df78 Gitweb: http://git.kernel.org/tip/3415d8b851307c75a1e8aa16030db9172306df78 Author: Stanislav Fomichev <stfomichev@yandex-team.ru> AuthorDate: Mon, 20 Jan 2014 15:39:38 +0400 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Mon, 20 Jan 2014 16:19:08 -0300
perf timechart: Fix wrong SVG height
If we call perf timechart with -p 0 arguments, it means we don't want any tasks related data. It works, but space for tasks data is reserved in the generated SVG. Remove this unused empty space via passing 0 as count to the open_svg.
Signed-off-by: Stanislav Fomichev <stfomichev@yandex-team.ru> Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: David Ahern <dsahern@gmail.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/1390217980-22424-2-git-send-email-stfomichev@yandex-team.ru Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/builtin-timechart.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/tools/perf/builtin-timechart.c b/tools/perf/builtin-timechart.c index 652af0b..25526d6 100644 --- a/tools/perf/builtin-timechart.c +++ b/tools/perf/builtin-timechart.c @@ -1045,6 +1045,9 @@ static void write_svg_file(struct timechart *tchart, const char *filename) thresh /= 10; } while (!process_filter && thresh && count < tchart->proc_num); + if (!tchart->proc_num) + count = 0; + open_svg(filename, tchart->numcpus, count, tchart->first_time, tchart->last_time); svg_time_grid();
| |