Messages in this thread | | | Date | Thu, 23 Jan 2014 16:53:50 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH 1/2] PWM: let of_xlate handlers check args count |
| |
On Thu, Jan 23, 2014 at 12:04:44PM +0100, Sascha Hauer wrote: > On Thu, Jan 23, 2014 at 11:56:32AM +0100, Lothar Waßmann wrote: > > Hi, > > > > Sascha Hauer wrote: > > > of_pwm_n_cells for the of_xlate handler is stored in struct pwm_chip, > > > but it is only ever used by the of_xlate handler itsel. Remove > > > of_pwm_n_cells from struct pwm_chip and let the handler do the argument > > > count checking to simplify the code. > > > > > This still does not make the PWM_POLARITY flag in the pwms node > > optional as was the goal because of_parse_phandle_with_args() requires > > at least #pwm-cells arguments in the node. > > > > So, with a DT configuration like: > > pwm0: pwm@0 { > > #pwm-cells = <3>; > > }; > > backlight { > > pwms = <&pwm0 0 100000>; > > }; > > We misunderstood each other. My goal was to allow the driver to also > work with old devicetrees which specify #pwm-cells = <2>, not to allow > inconsistent devicetrees like the snippet above.
In which case, the patch I've posted seems to do that job too... I'm just about to test out the three-cell version.
-- FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. Estimate before purchase was "up to 13.2Mbit". -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |