lkml.org 
[lkml]   [2014]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip 4/8] perf-probe: Use the actual address instead of the symbol name
On Thu, 23 Jan 2014 11:52:11 -0300
Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:

> Em Thu, Jan 23, 2014 at 02:29:55AM +0000, Masami Hiramatsu escreveu:
> > Since several local symbols can have same name (e.g. t_show),
> > we need to use the actual address instead of symbol name for
> > those points. Note that this works only with debuginfo.
> >
> > E.g. without this change;
> > ----
>
> Please use spaces after dashed lines, this is even as (or more)
> important as prefixing # lines, as this makes everything after the ---
> line and the patch itself to be ignored.
>

You recommend after? I found adding a single space before the dashes
better, as that way I know I added one and didn't forget to.

-- Steve


\
 
 \ /
  Last update: 2014-01-23 17:41    [W:0.069 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site