Messages in this thread | | | Date | Thu, 23 Jan 2014 11:12:37 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH -tip 4/8] perf-probe: Use the actual address instead of the symbol name |
| |
On Thu, 23 Jan 2014 11:52:11 -0300 Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:
> Em Thu, Jan 23, 2014 at 02:29:55AM +0000, Masami Hiramatsu escreveu: > > Since several local symbols can have same name (e.g. t_show), > > we need to use the actual address instead of symbol name for > > those points. Note that this works only with debuginfo. > > > > E.g. without this change; > > ---- > > Please use spaces after dashed lines, this is even as (or more) > important as prefixing # lines, as this makes everything after the --- > line and the patch itself to be ignored. >
You recommend after? I found adding a single space before the dashes better, as that way I know I added one and didn't forget to.
-- Steve
| |