Messages in this thread | | | Date | Thu, 23 Jan 2014 15:55:45 +0000 | From | Lee Jones <> | Subject | Re: [PATCH RESEND v4 01/37] mtd: st_spi_fsm: Allocate resources and register with MTD framework |
| |
> >+ fsm->region = devm_request_mem_region(&pdev->dev, res->start, > >+ resource_size(res), pdev->name); > >+ if (!fsm->region) { > >+ dev_err(&pdev->dev, > >+ "Failed to reserve memory region [0x%08x-0x%08x]\n", > >+ res->start, res->end); > >+ return -EBUSY; > >+ } > >+ > >+ fsm->base = devm_ioremap_nocache(&pdev->dev, > >+ res->start, resource_size(res)); > >+ if (!fsm->base) { > >+ dev_err(&pdev->dev, "Failed to ioremap [0x%08x]\n", res->start); > >+ return -EINVAL; > >+ } > >+ > you can replace "devm_request_mem_region" & "devm_ioremap_nocache" > by "devm_ioremap_resource"
Yes, that looks entirely reasonable, thanks.
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |