[lkml]   [2014]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 19/73] arm: mach-s3c64xx mach-crag6410-module.c is not modular
On Tue, Jan 21, 2014 at 04:22:22PM -0500, Paul Gortmaker wrote:
> Despite the name mach-crag6410-module.c, the code is built for
> MACH_WLF_CRAGG_6410 -- which is bool, and hence this code is
> either present or absent. It will never be modular, so using
> module_init as an alias for __initcall can be somewhat
> misleading.
> Fix this up now, so that we can relocate module_init from
> init.h into module.h in the future. If we don't do this, we'd
> have to add module.h to obviously non-modular code, and that
> would be a worse thing.
> Note that direct use of __initcall is discouraged, vs. one
> of the priority categorized subgroups. As __initcall gets
> mapped onto device_initcall, our use of device_initcall
> directly in this change means that the runtime impact is
> zero -- it will remain at level 6 in initcall ordering.
> Cc: Ben Dooks <>
> Cc: Kukjin Kim <>
> Cc: Russell King <>
> Cc:
> Cc:
> Signed-off-by: Paul Gortmaker <>
> ---

Tested-by: Charles Keepax <>


 \ /
  Last update: 2014-01-23 15:01    [W:0.580 / U:6.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site