Messages in this thread | | | Date | Wed, 22 Jan 2014 10:30:20 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [PATCH] Add HID's to hid-microsoft driver of Surface Type/Touch Cover 2 to fix bug |
| |
On Tue, 21 Jan 2014, Benjamin Tissoires wrote:
> > From 291742873dcf181faf9657b41279487f31302c73 Mon Sep 17 00:00:00 2001 > > From: Reyad Attiyat <reyad.attiyat@gmail.com> > > Date: Tue, 21 Jan 2014 01:22:25 -0600 > > Subject: [PATCH 1/1] Added in HID's for Microsoft Surface Type/Touch cover 2. > > This is to fix bug 64811 where this device is detected as a multitouch device > > > > You are missing a commit message here (the first message you sent > would fit perfectly here).
Also it's missing a Signed-off-by: line and Reyad's mail client damaged the patch by line-wrapping.
> So to sum up, with the commit message amended: > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Reyad, please do a full resubmission with
- proper changelog - Signed-off-by: line added - Benjamin's Reviewed-by: line added - your mail client fixed so that it doesn't damage the patch
I'll then queue the patch in my tree.
Thanks,
-- Jiri Kosina SUSE Labs
| |