Messages in this thread | | | Date | Wed, 22 Jan 2014 12:41:07 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH V5 2/3] mm/memblock: Add support for excluded memory areas |
| |
On Wed, 22 Jan 2014 12:18:21 +0100 Philipp Hachtmann <phacht@linux.vnet.ibm.com> wrote:
> Hi again, > > I'd like to remind that the s390 development relies on this patch > (and the next one, for cleanliness, of course) being added. It would be > very good to see it being added to the -mm tree resp. linux-next. >
Once the patch has passed review (hopefully by yinghai, who reviews very well) I'd ask you to include it in the s390 tree which actually uses it.
Patch 2/3 would benefit from a more complete changelog. Why does s390 need CONFIG_ARCH_MEMBLOCK_NOMAP? How is it used and how does it work? Do we expect other architectures to use it? If so, how? etcetera.
btw, you have a "#ifdef ARCH_MEMBLOCK_NOMAP" in there which should be CONFIG_ARCH_MEMBLOCK_NOMAP. I don't see how the code could have compiled as-is - __next_mapped_mem_range() will be omitted?
| |