lkml.org 
[lkml]   [2014]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [BISECTED] Linux 3.12.7 introduces page map handling regression
From
On Wed, Jan 22, 2014 at 10:07 AM, Rik van Riel <riel@redhat.com> wrote:
>
> The difference between a numa pte and a protnone pte is
> the VMA permissions.

If that is indeed the only difference, then we should damn well get
rid of that f*cking stupid _PAGE_NUMA name entirely.

It's misleading crap. Really. Just do a quick grep for that bit, and
you see just *how* confused people are about it:

#define _PAGE_NUMA _PAGE_PROTNONE
...
if ((pte_flags(a) & (_PAGE_PROTNONE | _PAGE_NUMA)) &

think about it. Just *THINK* about how broken that code is. The whole
thing is a disaster. _PAGE_NUMA must die. It's shit.

Linus


\
 
 \ /
  Last update: 2014-01-22 20:01    [W:0.107 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site