lkml.org 
[lkml]   [2014]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: don't introduce more __cpuinit users in intel_mid_weak_decls.h
On 14-01-22 11:59 AM, Paul Gortmaker wrote:
> Commit 85611e3febe78955a519f5f9eb47b941525c8c76 ("x86, intel-mid:
> Add Clovertrail platform support") added new instances of __cpuinit
> usage. We removed this a couple versions ago; we now want to remove
> the compat no-op stubs. Introducing new users is not what we want to
> see at this point in time, as it will break once the stubs are gone.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Cc: David Cohen <david.a.cohen@linux.intel.com>
> Cc: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> Cc: Fei Yang <fei.yang@intel.com>
> Cc: H. Peter Anvin <hpa@linux.intel.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>
> [patch will be added to init cleanup series:
> http://git.kernel.org/cgit/linux/kernel/git/paulg/init.git/ ]
>
> arch/x86/platform/intel-mid/intel_mid_weak_decls.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/platform/intel-mid/intel_mid_weak_decls.h b/arch/x86/platform/intel-mid/intel_mid_weak_decls.h
> index a537ffc16299..41fe17d0d8ff 100644
> --- a/arch/x86/platform/intel-mid/intel_mid_weak_decls.h
> +++ b/arch/x86/platform/intel-mid/intel_mid_weak_decls.h
> @@ -14,6 +14,6 @@
> /* For every CPU addition a new get_<cpuname>_ops interface needs
> * to be added.
> */
> -extern void * __cpuinit get_penwell_ops(void) __attribute__((weak));
> -extern void * __cpuinit get_cloverview_ops(void) __attribute__((weak));
> +extern void *get_penwell_ops(void) __attribute__((weak));
> +extern void *get_cloverview_ops(void) __attribute__((weak));
> extern void * __init get_tangier_ops(void) __attribute__((weak));

Sent stale copy w/o git-add on the actual file containing the functions
themselves ; will resend v2 shortly after I double check testing...

P.
--

>


\
 
 \ /
  Last update: 2014-01-22 18:42    [W:2.098 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site