Messages in this thread | | | Date | Wed, 22 Jan 2014 08:47:50 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH v3] ims-pcu: Add commands supported by the new version of the FW |
| |
On Wed, Jan 22, 2014 at 05:20:25AM -0800, Andrey Smirnov wrote: > +static int ims_pcu_write_ofn_config(struct ims_pcu *pcu, u8 addr, u8 data) > +{ > + u8 buffer[] = { addr, data }; > + int error; > + u16 result; > + > + error = ims_pcu_execute_command(pcu, OFN_SET_CONFIG, > + &buffer, sizeof(buffer)); > + if (error) > + return error; > + > + result = (s16)get_unaligned_le16(pcu->cmd_buf + OFN_REG_RESULT_OFFSET); > + if ((result < 0)
I am fairly certain this does not even compile, but even if it did, result is declared u16 so even if you do the cast above the comparison will always be false.
Thanks.
-- Dmitry
| |