Messages in this thread | | | Date | Tue, 21 Jan 2014 14:22:21 -0800 (PST) | From | David Rientjes <> | Subject | Re: [PATCH 1/3] mm: vmscan: shrink_slab: rename max_pass -> freeable |
| |
On Fri, 17 Jan 2014, Vladimir Davydov wrote:
> The name `max_pass' is misleading, because this variable actually keeps > the estimate number of freeable objects, not the maximal number of > objects we can scan in this pass, which can be twice that. Rename it to > reflect its actual meaning. > > Signed-off-by: Vladimir Davydov <vdavydov@parallels.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Mel Gorman <mgorman@suse.de> > Cc: Michal Hocko <mhocko@suse.cz> > Cc: Johannes Weiner <hannes@cmpxchg.org> > Cc: Rik van Riel <riel@redhat.com> > Cc: Dave Chinner <dchinner@redhat.com> > Cc: Glauber Costa <glommer@gmail.com>
This doesn't compile on linux-next:
mm/vmscan.c: In function ‘shrink_slab_node’: mm/vmscan.c:300:23: error: ‘max_pass’ undeclared (first use in this function) mm/vmscan.c:300:23: note: each undeclared identifier is reported only once for each function it appears in
because of b01fa2357bca ("mm: vmscan: shrink all slab objects if tight on memory") from an author with a name remarkably similar to yours. Could you rebase this series on top of your previous work that is already in -mm? | |