lkml.org 
[lkml]   [2014]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v9 3/5] qrwlock, x86 - Treat all data type not bigger than long as atomic in x86
    From
    On Tue, Jan 21, 2014 at 8:09 AM, Waiman Long <waiman.long@hp.com> wrote:
    >
    > include/linux/compiler.h:
    >
    > #ifndef __native_word
    > # ifdef __arch_native_word(t)
    > # define __native_word(t) __arch_native_word(t)
    > # else
    > # define __native_word(t) (sizeof(t) == sizeof(int) || sizeof(t) == siizeof(long))
    > # endif
    > #endif

    Do we even really need this?

    I'd suggest removing it entirely. You might want to retain the whole

    compiletime_assert_atomic_type()

    thing on purely the alpha side, but then it's all inside just the
    alpha code, without any need for this "native_word" thing.

    And if somebody tries to do a "smp_store_release()" on a random
    structure or union, do we care? We're not some nanny state that wants
    to give nice warnings for insane code.

    Linus


    \
     
     \ /
      Last update: 2014-01-22 01:41    [W:2.779 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site