Messages in this thread | | | Subject | Re: [PATCH] drivers/hid/wacom: fixed coding style issues | From | Joe Perches <> | Date | Tue, 21 Jan 2014 13:25:54 -0800 |
| |
On Tue, 2014-01-21 at 13:18 -0800, Dmitry Torokhov wrote: > On Tue, Jan 21, 2014 at 09:29:44PM +0100, Rob Schroer wrote: > > As far as I can see, kstrtoXXX() might be an alternative, but I was just > > fixing coding style issues, no need to break anything IMO. > > You could do the breaking in a follow up patch ;)
Yes please.
Include the breaking of multiple statements into multiple lines too please like
from: case USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH: rep_data[0] = 0x03; rep_data[1] = 0x00;
to: case USB_DEVICE_ID_WACOM_GRAPHIRE_BLUETOOTH: rep_data[0] = 0x03; rep_data[1] = 0x00;
| |