Messages in this thread | | | Date | Tue, 21 Jan 2014 10:16:43 -0500 | From | Dave Jones <> | Subject | Re: staging: vt6656: device.h Remove typedef enum __device_init_type. |
| |
On Tue, Jan 21, 2014 at 12:21:30AM +0000, Linux Kernel wrote: > Gitweb: http://git.kernel.org/linus/;a=commit;h=302433daf47aeb7d21d66e55fb84d6a8fffd4aed > Commit: 302433daf47aeb7d21d66e55fb84d6a8fffd4aed > Parent: a72f8beeedc97b776799a1a80c04eb5312980c9b > Author: Malcolm Priestley <tvboxspy@gmail.com> > AuthorDate: Sun Nov 3 17:40:51 2013 +0000 > Committer: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > CommitDate: Mon Nov 11 16:31:00 2013 -0800 > > staging: vt6656: device.h Remove typedef enum __device_init_type. > > Since typedef enum __device_init_type is only ever called > in one state. > > Remove the typedef from main_usb.c:device_init_registers and > replace with macro values. The other values may be needed later. > > Apply cold value to sInitCmd.byInitClass. > > Remove if braces and correct formatting within.
...
> /* load power table */ > for (ii = 0; ii < 14; ii++) { > - pDevice->abyCCKPwrTbl[ii] = pDevice->abyEEPROM[ii + EEP_OFS_CCK_PWR_TBL]; > - if (pDevice->abyCCKPwrTbl[ii] == 0) > - pDevice->abyCCKPwrTbl[ii] = pDevice->byCCKPwr; > - pDevice->abyOFDMPwrTbl[ii] = pDevice->abyEEPROM[ii + EEP_OFS_OFDM_PWR_TBL]; > - if (pDevice->abyOFDMPwrTbl[ii] == 0) > - pDevice->abyOFDMPwrTbl[ii] = pDevice->byOFDMPwrG; > - } > + pDevice->abyCCKPwrTbl[ii] = > + pDevice->abyEEPROM[ii + EEP_OFS_CCK_PWR_TBL]; > + > + if (pDevice->abyCCKPwrTbl[ii] == 0) > + pDevice->abyCCKPwrTbl[ii] = pDevice->byCCKPwr; > + pDevice->abyOFDMPwrTbl[ii] = > + pDevice->abyEEPROM[ii + EEP_OFS_OFDM_PWR_TBL]; > + if (pDevice->abyOFDMPwrTbl[ii] == 0) > + pDevice->abyOFDMPwrTbl[ii] = pDevice->byOFDMPwrG; > + }
Wrong indentation of the pDevice->abyOFDMPwrTbl[ii] assignment. Wrapping this to 80 columns has actually made this less readable imo.
Dave
| |