[lkml]   [2014]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 4/5 v3] input: tc3589x-keypad: support probing from device tree
On Tue, Jan 21, 2014 at 2:28 PM, Linus Walleij <> wrote:
> On Tue, Nov 26, 2013 at 3:34 AM, Dmitry Torokhov
> <> wrote:
>> On Tue, Nov 12, 2013 at 04:31:01PM +0100, Linus Walleij wrote:
>>> irq = platform_get_irq(pdev, 0);
>>> --
>> Don't you also want to add MODULE_DEVICE_TABLE entry?
> Probably, but that'd be a separate subject though, I think?
> I'll make a patch for this so you get something you can
> actually merge.

No, wait, this driver only matches on driver name, it has no
match table of any kind. This is typical for MFD-spun cells
if they don't need additional info from the compat match.
I think it only needs the MODULE_ALIAS() it already

Linus Walleij

 \ /
  Last update: 2014-01-21 15:21    [W:0.046 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site