Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [RFC/RFT][PATCH 4/5] ACPI / LPSS: Support for device latency tolerance PM QoS | Date | Mon, 20 Jan 2014 14:10:10 +0100 |
| |
On Monday, January 20, 2014 01:15:19 PM Mika Westerberg wrote: > On Fri, Jan 17, 2014 at 03:46:40PM +0100, Rafael J. Wysocki wrote: > > @@ -415,11 +472,12 @@ static int acpi_lpss_platform_notify(str > > return 0; > > } > > > > - if (action == BUS_NOTIFY_ADD_DEVICE) > > + if (action == BUS_NOTIFY_ADD_DEVICE) { > > ret = sysfs_create_group(&pdev->dev.kobj, &lpss_attr_group); > > - else if (action == BUS_NOTIFY_DEL_DEVICE) > > + pdev->dev.power.set_latency_tolerance = acpi_lpss_set_ltr; > > While trying to test this I noticed that BUS_NOTIFY_ADD_DEVICE happens > after call to dpm_sysfs_add(), so LTR field is never exposed to the > userspace.
Ahh, I confused things, thanks for reporting this!
I'll need to hook it up to acpi_platform_notify() somehow I think.
> > + } else if (action == BUS_NOTIFY_DEL_DEVICE) { > > sysfs_remove_group(&pdev->dev.kobj, &lpss_attr_group); > > - > > + } > > return ret; > > } > >
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |