Messages in this thread | | | From | Mike Turquette <> | Date | Sun, 19 Jan 2014 23:47:01 -0800 | Subject | Re: [PATCH] clk: export __clk_get_hw for re-use in others |
| |
On Sun, Jan 19, 2014 at 9:37 AM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Sun, Jan 19, 2014 at 02:55:07PM +0900, SeongJae Park wrote: >> Following build comes while modprobe process: >> > ERROR: "__clk_get_hw" [drivers/clk/clk-max77686.ko] undefined! >> > make[2]: *** [__modpost] Error 1 >> > make[1]: *** [modules] Error 2 >> >> Export the symbol to fix it and for other part's usecase. >> >> Signed-off-by: SeongJae Park <sj38.park@gmail.com> >> --- >> drivers/clk/clk.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c >> index 2b38dc9..3883fba 100644 >> --- a/drivers/clk/clk.c >> +++ b/drivers/clk/clk.c >> @@ -575,6 +575,7 @@ struct clk_hw *__clk_get_hw(struct clk *clk) >> { >> return !clk ? NULL : clk->hw; >> } >> +EXPORT_SYMBOL_GPL(__clk_get_hw); > > __ functions should usually only be for "internal" use, why does this > get exported to modules? Why not just put it in a .h file?
It was originally used only within the clock core but it is sensible for hardware-specific clock drivers to use this as well. I plan to audit all of the double-underscore functions in include/linux/clk-provider.h for 3.15.
Regards, Mike
> > greg k-h
| |