Messages in this thread | | | Date | Mon, 20 Jan 2014 14:48:16 +0000 | From | Matt Fleming <> | Subject | Re: [PATCH 5/5] efi: Split efi_enter_virtual_mode |
| |
On Mon, 20 Jan, at 02:46:25PM, Borislav Petkov wrote: > On Mon, Jan 20, 2014 at 01:44:07PM +0000, Matt Fleming wrote: > > > +void __init kexec_enter_virtual_mode(void) > > > +{ > > > > Could this be static for now? > > Didn't you wanna do arch/x86/platform/efi/kexec.c anyway?
Yes, but the patches are easier to review if we make kexec_enter_virtual_mode() global when moving it into a new file.
Plus it makes this patch that little bit smaller because the modification to efi.h is unnecessary.
-- Matt Fleming, Intel Open Source Technology Center
| |