Messages in this thread | | | Date | Mon, 20 Jan 2014 13:43:36 +0900 | From | Minchan Kim <> | Subject | Re: [RFC PATCH 1/3] zram: delete zram_init_device() function |
| |
Hello Sergey,
Looks good to me and I found a bug which had been in there so I rebased this patch on the top. https://git.kernel.org/cgit/linux/kernel/git/minchan/linux.git/commit/?h=zram-next&id=241e34fc6c3c1a41575fbe6383436be70df300d1
On Fri, Jan 17, 2014 at 02:04:15PM +0300, Sergey Senozhatsky wrote: > allocate new `zram_meta' in disksize_store() only for uninitialised > zram device, saving a number of allocations and deallocations in case > if disksize_store() was called on currently used device. at the same > time zram_meta stack variable is not necessary, because we can set > ->meta directly. there is also no need in setting QUEUE_FLAG_NONROT > queue on every disksize_store(), set it once during device creation. > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Otherwise,
Acked-by: Minchan Kim <minchan@kernel.org>
-- Kind regards, Minchan Kim
| |