Messages in this thread | | | Date | Sat, 18 Jan 2014 11:31:21 +0000 | From | Jonathan Cameron <> | Subject | Re: [PATCH 1/3] iio: mxs-lradc: fix buffer overflow |
| |
On 13/01/14 16:02, Alexandre Belloni wrote: > Fixes: > drivers/staging/iio/adc/mxs-lradc.c:1556 mxs_lradc_probe() error: buffer > overflow 'iio->channels' 15 <= 15 > > The reported available scales for in_voltage15 were also wrong. > > The realbits lookup is not necessary as all the channels of the LRADC have the > same resolution, use LRADC_RESOLUTION instead. > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com> Applied to the fixes-for-3.14new branch of iio.git. This will go upstream after 3.14-rc1 is tagged.
It's a little clunky having a simple array some of which isn't used for these but I guess it does give fairly simple code.
Thanks, > --- > drivers/staging/iio/adc/mxs-lradc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c > index df71669bb60e..aa86849daeba 100644 > --- a/drivers/staging/iio/adc/mxs-lradc.c > +++ b/drivers/staging/iio/adc/mxs-lradc.c > @@ -1613,7 +1613,7 @@ static int mxs_lradc_probe(struct platform_device *pdev) > * of the array. > */ > scale_uv = ((u64)lradc->vref_mv[i] * 100000000) >> > - (iio->channels[i].scan_type.realbits - s); > + (LRADC_RESOLUTION - s); > lradc->scale_avail[i][s].nano = > do_div(scale_uv, 100000000) * 10; > lradc->scale_avail[i][s].integer = scale_uv; >
| |