Messages in this thread | | | From | Jingchang Lu <> | Subject | RE: [PATCHv9 2/2] dma: Add Freescale eDMA engine driver support | Date | Fri, 17 Jan 2014 02:22:26 +0000 |
| |
> -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Sent: Thursday, January 16, 2014 7:03 PM > To: Lu Jingchang-B35083 > Cc: vinod.koul@intel.com; dan.j.williams@intel.com; shawn.guo@linaro.org; > pawel.moll@arm.com; mark.rutland@arm.com; swarren@wwwdotorg.org; linux- > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; Wang Huan-B18965 > Subject: Re: [PATCHv9 2/2] dma: Add Freescale eDMA engine driver support > > On Thursday 16 January 2014, Jingchang Lu wrote: > > Add Freescale enhanced direct memory(eDMA) controller support. > > This module can be found on Vybrid and LS-1 SoCs. > > > > Signed-off-by: Alison Wang <b18965@freescale.com> > > Signed-off-by: Jingchang Lu <b35083@freescale.com> > > Very nice! All my previous comments have been addressed, so > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > One small comment still: > > > + > > +static DEFINE_MUTEX(fsl_edma_mutex); > > + > > I think this mutex should be part of struct fsl_edma_engine, not global. Yes, it should be for each edma controller, I will define it in struct fsl_edma_engine. Thanks.
Best Regards, Jingchang
| |