lkml.org 
[lkml]   [2014]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 1/1] Drivers: hv: Implement the file copy service
On Tue, Jan 14, K. Y. Srinivasan wrote:

This function should return valid numbers:

> +static ssize_t fcopy_write(struct file *file, const char __user *buf,
> + size_t count, loff_t *ppos)
> +{
> + int error = 0;
> +
> + if (count != sizeof(int))
> + return 0;

Should be an error.

> +
> + if (copy_from_user(&error, buf, sizeof(int)))
> + return -EFAULT;
> +
> + if (in_hand_shake) {
> + fcopy_handle_handshake();
> + return 0;

Should be sizeof(int).

> + }
> +
> + /*
> + * Complete the transaction by forwarding the result
> + * to the host. But first, cancel the timeout.
> + */
> + if (cancel_delayed_work_sync(&fcopy_work))
> + fcopy_respond_to_host(error);
> +
> + return sizeof(int);
> +}



\
 
 \ /
  Last update: 2014-01-16 13:01    [W:0.823 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site