Messages in this thread | | | Date | Thu, 16 Jan 2014 12:24:51 +0800 | From | Jason Wang <> | Subject | Re: [PATCH net-next RFC] virtio-net: drop rq->max and rq->num |
| |
On 01/16/2014 08:46 AM, David Miller wrote: > From: Rusty Russell<rusty@rustcorp.com.au> > Date: Thu, 16 Jan 2014 10:25:26 +1030 > >> Rusty Russell<rusty@rustcorp.com.au> writes: >>> Jason Wang<jasowang@redhat.com> writes: >>>> It looks like there's no need for those two fields: >>>> >>>> - Unless there's a failure for the first refill try, rq->max should be always >>>> equal to the vring size. >>>> - rq->num is only used to determine the condition that we need to do the refill, >>>> we could check vq->num_free instead. >>>> - rq->num was required to be increased or decreased explicitly after each >>>> get/put which results a bad API. >>>> >>>> So this patch removes them both to make the code simpler. >>> Nice. These fields date from when the vq struct was opaque. >>> >>> Applied, >>> Rusty. >> Oops, this doesn't require any core virtio changes, so it's for DaveM: >> >> Acked-by: Rusty Russell<rusty@rustcorp.com.au> > Jason please repost this with Rusty's ACK, thanks.
Sure, will repost.
| |