Messages in this thread | | | Date | Wed, 15 Jan 2014 20:04:37 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump an arbitrary pagetable |
| |
On 01/15/2014 07:03 PM, Dave Young wrote: >> >> making something harder to grep and less standardized is hardly cleaner >> and these things compile to nothing for non-modules. > > It's not nothing, just very small increasement: > text data bss dec hex filename > 7636121 1391824 9355264 18383209 1188169 vmlinux > > text data bss dec hex filename > 7636113 1391824 9355264 18383201 1188161 vmlinux > > I do not want to insist on this minor problem, if you want please keep it. >
Now *that* we can fix by making these macros expand to nothing if you are compiling for a nonmodule, right? That will benefit code that legitimately can compile as a module but is configured "y", too.
-hpa
| |