Messages in this thread | | | Date | Wed, 15 Jan 2014 22:23:49 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH 09/12] tools lib traceevent: Unregister handler when cfg80211 plugin unloaded |
| |
On Thu, 16 Jan 2014 11:31:15 +0900 Namhyung Kim <namhyung@kernel.org> wrote:
> The function handler should be unregistered when the plugin unloaded > otherwise it'll try to access invalid memory. > > Reviewed-by: Jiri Olsa <jolsa@redhat.com> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
You can add my Acked-by to patches 9-12 too.
-- Steve
> --- > tools/lib/traceevent/plugin_cfg80211.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tools/lib/traceevent/plugin_cfg80211.c b/tools/lib/traceevent/plugin_cfg80211.c > index 57e98221db20..c066b25905f8 100644 > --- a/tools/lib/traceevent/plugin_cfg80211.c > +++ b/tools/lib/traceevent/plugin_cfg80211.c > @@ -22,3 +22,9 @@ int PEVENT_PLUGIN_LOADER(struct pevent *pevent) > PEVENT_FUNC_ARG_VOID); > return 0; > } > + > +void PEVENT_PLUGIN_UNLOADER(struct pevent *pevent) > +{ > + pevent_unregister_print_function(pevent, process___le16_to_cpup, > + "__le16_to_cpup"); > +}
| |