lkml.org 
[lkml]   [2014]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/2 v3] ixgbe: define IXGBE_MAX_VFS_DRV_LIMIT macro and cleanup const 63
    From
    Aaron,

    Is this your net-next repo ? if so, I rebuild the patch with this repo
    right now .
    git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next.git

    Thanks,
    Ethan

    On Thu, Jan 16, 2014 at 9:54 AM, Brown, Aaron F <aaron.f.brown@intel.com> wrote:
    > On Thu, 2014-01-16 at 09:27 +0800, Ethan Zhao wrote:
    >> On Thu, Jan 16, 2014 at 6:00 AM, Brown, Aaron F <aaron.f.brown@intel.com> wrote:
    >> > On Wed, 2014-01-15 at 22:12 +0800, Ethan Zhao wrote:
    >> >> Because ixgbe driver limit the max number of VF functions could be enabled
    >> >> to 63, so define one macro IXGBE_MAX_VFS_DRV_LIMIT and cleanup the const 63
    >> >> in code.
    >> >>
    >> >> v2: fix a typo.
    >> >> v3: fix a encoding issue.
    >> >>
    >> >> Signed-off-by: Ethan Zhao <ethan.kernel@gmail.com>
    >> >> ---
    >> >> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++--
    >> >> drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 5 +++--
    >> >> drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.h | 5 +++++
    >> >> 3 files changed, 10 insertions(+), 4 deletions(-)
    >> >>
    >> >> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
    >> >> index 0ade0cd..47e9b44 100644
    >> >> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
    >> >> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
    >> >> @@ -4818,7 +4818,7 @@ static int ixgbe_sw_init(struct ixgbe_adapter *adapter)
    >> >> #ifdef CONFIG_PCI_IOV
    >> >> /* assign number of SR-IOV VFs */
    >> >> if (hw->mac.type != ixgbe_mac_82598EB)
    >> >> - adapter->num_vfs = (max_vfs > 63) ? 0 : max_vfs;
    >> >
    >> >
    >> > Unfortunately the if statement got changed considerably with a recent
    >> > commit:
    >> >
    >> > commit 170e85430bcbe4d18e81b5a70bb163c741381092
    >> > ixgbe: add warning when max_vfs is out of range.
    >> >
    >> > And the pattern no longer exists to make a match. In other words, this
    >> > patch no longer applies to net-next and I have to ask you for yet
    >> > another spin if you still want to squash the magic number.
    >>
    >> It's not a good news. Our distro is waiting for this patch showing up in stable.
    >> OK, info me if there is a windows for me to revise the patch.
    >
    > I don't think any particular window of time is better than another. I
    > don't see this change as needing very thorough testing so if you send in
    > (yet) another version I'll try to get it through our internal process as
    > rapidly as I can.
    >
    >>
    >> Thanks,
    >> Ethan
    >>
    >> >
    >> > Thanks,
    >> > Aaron
    >


    \
     
     \ /
      Last update: 2014-01-16 04:21    [W:4.727 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site