Messages in this thread | | | Date | Thu, 16 Jan 2014 02:11:41 +0200 | From | "Kirill A. Shutemov" <> | Subject | Re: [RFC][PATCH 1/9] mm: slab/slub: use page->list consistently instead of page->lru |
| |
On Tue, Jan 14, 2014 at 10:00:44AM -0800, Dave Hansen wrote: > > From: Dave Hansen <dave.hansen@linux.intel.com> > > 'struct page' has two list_head fields: 'lru' and 'list'. > Conveniently, they are unioned together. This means that code > can use them interchangably, which gets horribly confusing like > with this nugget from slab.c: > > > list_del(&page->lru); > > if (page->active == cachep->num) > > list_add(&page->list, &n->slabs_full); > > This patch makes the slab and slub code use page->lru > universally instead of mixing ->list and ->lru. > > So, the new rule is: page->lru is what the you use if you want to > keep your page on a list. Don't like the fact that it's not > called ->list? Too bad. > > Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
-- Kirill A. Shutemov
| |