Messages in this thread | | | Date | Wed, 15 Jan 2014 15:36:26 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH 16/17] tools lib traceevent: Unregister handler when scsi plugin unloaded |
| |
On Wed, 15 Jan 2014 10:45:39 +0900 Namhyung Kim <namhyung@kernel.org> wrote:
> The function handler should be unregistered when the plugin unloaded > otherwise it'll try to access invalid memory. > > Cc: Jiri Olsa <jolsa@redhat.com> > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > --- > tools/lib/traceevent/plugin_scsi.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/tools/lib/traceevent/plugin_scsi.c b/tools/lib/traceevent/plugin_scsi.c > index 6fb8e3e3fcad..64d688534518 100644 > --- a/tools/lib/traceevent/plugin_scsi.c > +++ b/tools/lib/traceevent/plugin_scsi.c > @@ -421,3 +421,10 @@ int PEVENT_PLUGIN_LOADER(struct pevent *pevent) > PEVENT_FUNC_ARG_VOID); > return 0; > } > + > +void PEVENT_PLUGIN_UNLOADER(struct pevent *pevent) > +{ > + pevent_unregister_print_function(pevent, > + process_scsi_trace_parse_cdb, > + "scsi_trace_parse_cdb"); > +}
Seems we have a trend ;-)
Same for patch 17.
-- Steve
| |