Messages in this thread | | | Date | Wed, 15 Jan 2014 14:40:39 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH 2/3] tools lib traceevent: fix pointer-integer size mismatch |
| |
On Wed, 15 Jan 2014 15:14:06 -0300 Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:
> Em Wed, Jan 15, 2014 at 10:44:07AM +0000, Mark Rutland escreveu: > > The scsi and cfg80211 plugins cast between unsigned long long and > > pointers, which is problematic for architectures where unsigned long > > long is wider than the native pointer size: > > > > linux/tools/lib/traceevent/plugin_scsi.c: In function ‘process_scsi_trace_parse_cdb’: > > linux/tools/lib/traceevent/plugin_scsi.c:408:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > > scsi_trace_parse_cdb(s, (unsigned char *) args[1], args[2]); > > > > linux/tools/lib/traceevent/plugin_cfg80211.c: In function ‘process___le16_to_cpup’: > > linux/tools/lib/traceevent/plugin_cfg80211.c:11:18: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > > uint16_t *val = (uint16_t *) args[0]; > > > > This patch adds an intermediate cast to unsigned long, silencing the > > warning. > > Steven, Jiri: Acked-by?
Yep, that's the correct solution.
Acked-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
> > > Signed-off-by: Mark Rutland <mark.rutland@arm.com>
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |