Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 3/3] perf tools: Remove unnecessary callchain cursor state restore on unmatch | Date | Wed, 15 Jan 2014 15:24:47 +0900 |
| |
On Tue, 14 Jan 2014 16:37:16 +0100, Frederic Weisbecker wrote: > If a new callchain branch doesn't match a single entry of the node that > it is given against comparison in append_chain(), then the cursor is > expected to be at the same position as it was before the comparison loop. > > As such, there is no need to restore the cursor position on exit in case > of non matching branches. > > Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Thanks, Namhyung
| |