Messages in this thread | | | Date | Wed, 15 Jan 2014 16:02:53 +0100 | From | Hannes Frederic Sowa <> | Subject | Re: [PATCH RFC] reciprocal_divide: correction/update of the algorithm |
| |
On Tue, Jan 14, 2014 at 10:02:19AM -0800, Randy Dunlap wrote: > Just trivia (coding style and spelling): > > > diff --git a/lib/reciprocal_div.c b/lib/reciprocal_div.c > > index 75510e9..b741b30 100644 > > --- a/lib/reciprocal_div.c > > +++ b/lib/reciprocal_div.c > > @@ -1,11 +1,25 @@ > > +#include <linux/kernel.h> > > #include <asm/div64.h> > > #include <linux/reciprocal_div.h> > > #include <linux/export.h> > > > > -u32 reciprocal_value(u32 k) > > +/* For a description of the algorithmus please look at > > algorithms > > > + * linux/reciprocal_div.h > > + */ > > and kernel coding style for multi-line comments is like so: > > /* > * For a description of the algorithms, please look at > * linux/reciprocal_div.h > */ > > > + > > +struct reciprocal_value reciprocal_value(u32 d) > > {
Thanks, fixed those stuff locally along with a better description. I am used to netdev comments. ;)
| |